Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run.util.js: Test building with msvs 2022 and get AppVeyor to pass #709

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

cclauss
Copy link

@cclauss cclauss commented Apr 11, 2024

To support newer versions of Node.js > v17

npm ci
npm run update-crosswalk

test/run.util.js

  if (process.platform === 'win32') {
-    final_cmd += ' --msvs_version=2015 ';
+    final_cmd += ' --msvs_version=2022 ';
  }

appveyor.yml

+ matrix:  # TODO: Fix the `configures with unparsed options` tests and remove this allow_failures matrix.
+   allow_failures:
+     - nodejs_version: 20
+     - nodejs_version: 21

AppVeyor test results: https://ci.appveyor.com/project/Mapbox/node-pre-gyp/history

@yhahn, @mapsam, @axrj, @rafaykh90, @ewanharris, @ronilan, @acalcutt Your reviews, please.

@cclauss cclauss changed the title run.util.js: Test building with msvs 2022 run.util.js: Test building with msvs 2022 and get AppVeyor to pass Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant