Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split sqlite3-binding.js out so that it could be override by webpack … #1268

Merged
merged 2 commits into from Mar 13, 2020
Merged

Split sqlite3-binding.js out so that it could be override by webpack … #1268

merged 2 commits into from Mar 13, 2020

Conversation

lygstate
Copy link
Contributor

@lygstate lygstate commented Jan 1, 2020

Fixes #909

@kewde kewde mentioned this pull request Feb 11, 2020
Closed
@kewde kewde mentioned this pull request Feb 25, 2020
Closed
bedwardly-down
bedwardly-down suggested changes Mar 8, 2020
View reviewed changes
Copy link

@bedwardly-down bedwardly-down left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can add a semicolon to the end of the modules.exports line in lib/sqlite3.js, you should be good to go. The CI builds are failing due to that missing.

bedwardly-down
bedwardly-down reviewed Mar 8, 2020
View reviewed changes
Copy link

@bedwardly-down bedwardly-down left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because i don't have permissions here, when i fixed it, it was wanting me to create a new pull request. Thanks for fixing that.

@kewde kewde merged commit fdceaef into TryGhost:master Mar 13, 2020
@rkistner rkistner mentioned this pull request Sep 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bedwardly-down bedwardly-down bedwardly-down approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Module not found: Error: Can't resolve 'node-pre-gyp'
3 participants
@lygstate @bedwardly-down @kewde