New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove @rollup/plugin-json #1894
Conversation
136e29a
to
cf8ef7e
Compare
I'm still not totally sure about this. I was getting some errors from Does Edit: I think it was due to the missing import asserts in some places. Now fixed. |
I found the reason for some other build problems with this PR and fixed upstream: ( |
Does this mean there's a need to use the yet to be released version of the assert plugin? |
Can you please rebase? The tests are failing due to a problem with ubuntu image changes. This is fixed in main. |
5462b8a
to
12993b6
Compare
Bundle size report: Size Change: 0 B
ℹ️ View DetailsNo major changes |
No, that should not be necessary. #1898 removes exposure to the upstream bug, so it should be merged first. |
Thanks for the info! what error did this issue created then? According to the topmost message, there's an issue that this PR fixes, how does this issue manifests? |
The issue is, as far as I can tell, just log noise at the moment. During the build process, the json plugin hits a parsing problem (it can't process the file, since it's not valid JSON after being processed by Since the |
This was conflicting with rollup-plugin-import-assert Add missing json import assertions
Rebased |
Scratch that. This does cause |
@rollup/plugin-json
androllup-plugin-import-assert
both convert imported JSON files to importable javascript modules. This means that, not only is only one needed, but the second one that runs on a given JSON file actually errors out. Since@rollup/plugin-json
is erroring out anyway, we remove it.Note that
rollup-plugin-import-assert
has an additional bug with importing JSON files from node modules. So this PR should probably be merged in after #1898 (which removes exposure to that bug) or after PR calebdwilliams/rollup-plugin-import-assert#11 (which fixes the upstream bug).Launch Checklist
CHANGELOG.md
under the## main
section.