Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup WebGL2 typings #2508

Merged
merged 3 commits into from
May 12, 2023
Merged

Cleanup WebGL2 typings #2508

merged 3 commits into from
May 12, 2023

Conversation

birkskyum
Copy link
Member

@birkskyum birkskyum commented May 12, 2023 •
edited

Continuation of #1891

Adding more typings for WebGL2RenderingContext.

Also, unused field variable on Painter emptyTexture: Texture; is removed.

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@birkskyum birkskyum requested a review from HarelM May 12, 2023 11:20
@birkskyum birkskyum mentioned this pull request May 12, 2023
Merged
9 tasks
@birkskyum birkskyum merged commit 1dda83f into maplibre:main May 12, 2023
12 of 13 checks passed
@birkskyum birkskyum added this to the 3.0.0 milestone May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarelM HarelM HarelM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@birkskyum @HarelM