Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate coverage reports #3589

Closed
wants to merge 3 commits into from
Closed

Investigate coverage reports #3589

wants to merge 3 commits into from

Conversation

HarelM
Copy link
Member

@HarelM HarelM commented Jan 15, 2024

I hope this will work...
This is not to be merge...

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7decb26) 85.92% compared to head (cbb96ce) 74.81%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3589       +/-   ##
===========================================
- Coverage   85.92%   74.81%   -11.11%     
===========================================
  Files         244      243        -1     
  Lines       48269    19211    -29058     
  Branches     5152     4260      -892     
===========================================
- Hits        41473    14373    -27100     
+ Misses       6796     4838     -1958     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM
Copy link
Member Author

HarelM commented Jan 15, 2024

I've opened the following bug:
istanbuljs/v8-to-istanbul#238
I'll see what I get from there, hopefully this will help solve this issue.

@HarelM
Copy link
Member Author

HarelM commented Jan 23, 2024

I understand the root cause of this issue.
This PR can be closed.

@HarelM HarelM closed this Jan 23, 2024
@HarelM HarelM deleted the investigate-coverage branch January 23, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants