Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't reuse git dir across runs node-ci and ios-ci #1182

Closed
wants to merge 5 commits into from
Closed

Don't reuse git dir across runs node-ci and ios-ci #1182

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
067c252
Don't reuse git dir across runs node-ci and ios-ci
louwers May 26, 2023
bed618e
Update .github/workflows/node-ci.yml
louwers May 26, 2023
fc92578
non-recursive checkout
louwers May 26, 2023
a4ccd60
delete ./ as workdir node-ci
louwers May 26, 2023
ffb7963
delete debug action
louwers May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ios-ci.yml
View file
Open in desktop
Expand Up @@ -66,6 +66,7 @@ jobs:
with:
submodules: recursive
fetch-depth: 0
path: ${{ github.sha }}

- name: Install macos dependencies
run: |
Expand Down
9 changes: 2 additions & 7 deletions .github/workflows/node-ci.yml
View file
Open in desktop
Expand Up @@ -88,13 +88,8 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 0

- name: Setup submodules
shell: bash
run: |
auth_header="$(git config --local --get http.https://github.com/.extraheader)"
git submodule sync --recursive
git -c core.longpaths=true -c "http.extraheader=$auth_header" -c protocol.version=2 submodule update --init --force --recursive || true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just an fyi, there is a reason we did it this way. On the windows platform the normal checkout has issues with long file names, which this got around.

It may be possible that with the recent reorg of files that this path issue was no longer a problem, but we would have to look out for that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember this causing problems for me cloning on my windows system but I just did a recursive clone and it seems fine now. I checked and I still have long path support disabled at the moment.

If I recall correctly it was test fixtures in a submodule that had extremely long file names which caused problems.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I am indeed running into that problem when I do a recursive merge.

submodules: true
louwers marked this conversation as resolved.
Show resolved Hide resolved
path: ${{ github.sha }}

- name: Get OS Architecture
if: runner.os == 'MacOS' || runner.os == 'Linux'
Expand Down