Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker support #4267

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Docker support #4267

wants to merge 1 commit into from

Conversation

mathisloge
Copy link
Collaborator

@mathisloge mathisloge commented Nov 15, 2021

related #3704 and #4153

What functionalities are added by this PR?

Pinging some people that were interested in the past: @knutole @hiddewie @jawg @Joxit

maybe we can work together or leave some reviews. I'm not a mapnik docker user myself

@Joxit
Copy link

Joxit commented Nov 15, 2021

Hi there,
Are you sure this will work with GA ? Is there no time limit for a running workflow ? IIRC, building mapnik takes time 😅

@mathisloge
Copy link
Collaborator Author

mathisloge commented Nov 15, 2021

hi @Joxit
it has already runned :D https://github.com/mathisloge/mapnik/runs/4214019688?check_suite_focus=true

But the limits for open source projects are actually quite high. each job can take up to 6 hours and a workflow up to 72 hours https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration

But the workflow only takes ~15 mins . so it is quite ok

@Joxit
Copy link

Joxit commented Nov 15, 2021

Oh, nice ! I will add GA on jawg/docker-mapnik3 then 😄

@mathisloge mathisloge changed the title [help-needed] Docker Docker support Nov 16, 2021
@mathisloge mathisloge marked this pull request as ready for review November 16, 2021 19:17
@mathisloge
Copy link
Collaborator Author

@artemp this should be ready to merge. There shouldn't be any actions needed other than a merge. The workflow would use the github context to get the secrets / repo names.

Each branch will have its own docker tag
Each tag labeled with v*.*.* will have its own docker tag.
The latest semver will get the latest docker tag

You can see some example tags here:
https://github.com/mathisloge/mapnik/pkgs/container/mapnik

Note, that this uses the cmake build. For node-mapnik or python-mapnik I will now find a way to use pkg-config instead of mapnik-config.

Or is there a desire to use SCons to build mapnik on the Docker image?

Dockerfile Outdated Show resolved Hide resolved
@mathisloge
Copy link
Collaborator Author

@hiddewie thanks for your reviews. I've added more dirs to the ignore list. So it is reduced to 33MB.
and splitted the commands as suggested.

@zy6p
Copy link

zy6p commented Dec 1, 2021

Looking forward to see this PR merged. This will help with some custom plugins we created.

@mathisloge
Copy link
Collaborator Author

@zy6p you could actually use the containers already. https://github.com/mathisloge/mapnik/pkgs/container/mapnik/10503672?tag=docker

@zy6p
Copy link

zy6p commented Dec 4, 2021

@zy6p you could actually use the containers already. mathisloge/mapnik/pkgs/container/mapnik/10503672?tag=docker

Great! My laptop is M1 mac, and pre-build mapnik doesnot support arm. But these containers can work 😃

Adds initial docker support

cluster apt commands

use apt-get

use single run command

delete at end

do not tag each commit

ldconfig for mapnik

use final repo

use github.repository for image url

apply suggestions

ignore more

[Docker] add container signing

install later

forgot id

[Docker] remove codesign
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants