New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker support #4267
base: master
Are you sure you want to change the base?
Docker support #4267
Conversation
Hi there, |
hi @Joxit But the limits for open source projects are actually quite high. each job can take up to 6 hours and a workflow up to 72 hours https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration But the workflow only takes ~15 mins . so it is quite ok |
Oh, nice ! I will add GA on jawg/docker-mapnik3 then 😄 |
487391c
to
bacd4c0
Compare
@artemp this should be ready to merge. There shouldn't be any actions needed other than a merge. The workflow would use the github context to get the secrets / repo names. Each branch will have its own docker tag You can see some example tags here: Note, that this uses the cmake build. For node-mapnik or python-mapnik I will now find a way to use pkg-config instead of Or is there a desire to use SCons to build mapnik on the Docker image? |
@hiddewie thanks for your reviews. I've added more dirs to the ignore list. So it is reduced to 33MB. |
Looking forward to see this PR merged. This will help with some custom plugins we created. |
@zy6p you could actually use the containers already. https://github.com/mathisloge/mapnik/pkgs/container/mapnik/10503672?tag=docker |
Great! My laptop is M1 mac, and pre-build mapnik doesnot support arm. But these containers can work 😃 |
Adds initial docker support cluster apt commands use apt-get use single run command delete at end do not tag each commit ldconfig for mapnik use final repo use github.repository for image url apply suggestions ignore more [Docker] add container signing install later forgot id [Docker] remove codesign
related #3704 and #4153
What functionalities are added by this PR?
ghcr.io/mathisloge/mapnik:docker
and laterghcr.io/mapnik/mapnik:docker
Pinging some people that were interested in the past: @knutole @hiddewie @jawg @Joxit
maybe we can work together or leave some reviews. I'm not a mapnik docker user myself