-
-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3133 Redundant null check in generated code when adding parameters #3583
base: main
Are you sure you want to change the base?
#3133 Redundant null check in generated code when adding parameters #3583
Conversation
67239e1
to
7016d48
Compare
- verify redundant null checks in mappings are avoided - targets mapper methods that involve update mappings and ensures that null checks are not applied redundantly if already covered - tests for multiple scenarios
0b95442
to
464cc8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you are formatting it is best to only format the changed lines and also when committing it is best to only stage changes that are not formatting changes.
I'll clean up the not needed formatting changes now, that's not a problem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aaaah... makes sense! Thanks for clearing that up 😁
9bc9826
to
82f7835
Compare
Somthing must be configured incorrectly in my IDE... I'm not sure why though |
fix for: #3133