Fix water_name_line source layer #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, might I add that it's currently hard to provide a small diff in a PR, because every time the style.json is saved through Maputnik, it reformats/prettifies the JSON. It might be nice if there was a separate PR just to reformat the style.json, so that new contributions could be made from changes made in Maputnik. |
|
@kylebarron nice spot, thanks!
Yeah, agree. We should find out why this was currently not the case, please see my comments in #66. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
water_namelayer only contains labeling points for lake bodies. To correctly label rivers, the source needs to be set to waterway, which has anamefield from OSM.Before, no labels on rivers, after:
