chore: sampling should set the result

maraisr · May 5, 2023 · 2a10857 · 2a10857
1 parent ee009ac
commit 2a10857
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/async.ts b/src/async.ts
@@ -52,8 +52,8 @@ export function span(name: string, parent_id?: Traceparent | string) {
 	const should_sample =
 		typeof sampler !== 'boolean' ? sampler(name, id, scope) : sampler;
 
-	if (should_sample) id.flags | SAMPLED_FLAG;
-	else id.flags & ~SAMPLED_FLAG;
+	if (should_sample) id.flags |= SAMPLED_FLAG;
+	else id.flags &= ~SAMPLED_FLAG;
 
 	const span_obj: Span = {
 		id,

diff --git a/src/index.ts b/src/index.ts
@@ -29,8 +29,8 @@ export function tracer(name: string, options?: Options): Tracer {
 		const should_sample =
 			typeof sampler !== 'boolean' ? sampler(name, id, scope) : sampler;
 
-		if (should_sample) id.flags | SAMPLED_FLAG;
-		else id.flags & ~SAMPLED_FLAG;
+		if (should_sample) id.flags |= SAMPLED_FLAG;
+		else id.flags &= ~SAMPLED_FLAG;
 
 		const span_obj: Span = {
 			id,