gitlab throttling + adaptation to gitlab api changes + more logging for troubleshooting #256
Conversation
yaman
commented
Jan 11, 2023
yaman
commented
- gitlab api was rejecting requests for large groups with many projects, added throttling
- gitlab api changes broke the whole requests, changed the request types and structure to allow group/subgroup projects to be retrieved successfully
- added configuration for debug option to enable/disable verbose logging
- added configuration to define main group to only allow projects to be monitored under main group recursively
…related gitlab apis to query pipelines successfully
| @@ -111,6 +111,10 @@ monitor.run(); | |||
|
|
|||
| // helpers | |||
| function tryExpandEnvironmentVariables(monitorConfiguration, serviceConfiguration) { | |||
| if (process.env.TOKEN) { | |||
There was a problem hiding this comment.
Please revert this change. This should happen automatically by tryExpandEnvironmentVariable, if expandEnvironmentVariables is set to true.
| @@ -1,11 +1,16 @@ | |||
| version: '3' | |||
| version: '3.9' | |||
There was a problem hiding this comment.
Please revert all changes in this file.
| @@ -20,4 +20,4 @@ | |||
| } | |||
There was a problem hiding this comment.
Please revert all changes in this file.
| | `intervals` | How often (in integer of milliseconds) ... | ||
| | `additional_query` | Add [additional query parameters](https://gitlab.com/help/api/projects.md) so not too many projects are fetched. | ||
| | `main_group` | Gitlab needs a main group to analyze the project only you want to monitor, otherwise, you will get the whole world. |
There was a problem hiding this comment.
What happens, if this property is not set? Will existing GitLab configurations crash after an upgrade of the build monitor?
| @@ -14,4 +14,4 @@ ONBUILD ADD config.json /build-mon/app/config.json | |||
|
|
|||
There was a problem hiding this comment.
Please revert all changes in this file.
| @@ -1,100 +1,44 @@ | |||
| name: Build and Release | |||
| # This workflow uses actions that are not certified by GitHub. | |||
There was a problem hiding this comment.
Please revert all changes in this file.
| pipelines = pipelines.filter(function(pipeline) { | ||
| //console.log(pipeline); |
There was a problem hiding this comment.
Please remove unnecessary code.
| if (getHasWarnings(detailed_status)) { | ||
| return '#ffa500'; | ||
| } | ||
| // if (getHasWarnings(detailed_status)) { |
There was a problem hiding this comment.
Why is this removed? How are warnings handled now?
