[#111] Make styleId an optional string or function #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-prontera
requested changes
Jul 29, 2023
|
@marco-prontera I made the requested changes. |
marco-prontera
requested changes
Aug 7, 2023
There was a problem hiding this comment.
Hi @pedrosousa13, I talked to other contributors about what they think and we ended up not introducing this dependency but changing the styleId so that it is also possible to configure a callback which in this case will be called every time for every css file injection.
Can you change the code?
|
yeah totally. will make the change. |
|
@marco-prontera changes made, it now accepts a callback function. I also like this implementation :) |
marco-prontera
approved these changes
Aug 7, 2023
marco-prontera
changed the title
marco-prontera
added a commit
that referenced
this pull request
Aug 7, 2023
* feat: allow for unique styleId when relativeCssInjection * fix: remove dash when there is no styleId * fix: only run changes if styleId exists * fix: move uuid to devDependencies + update README * fix: PR comments * fix: remove empty line * fix: remove empty line * fix: remove empty line * fix: remove unused duplicate test * refactor: styleId as callback function 3.3.0
|
Hi @pedrosousa13, I published the new version 3.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a build that builds out css with
relativeCSSInjection. I would like to have style tags with different id's as so not to clash.Using this with the SSR approach that I modified in my style injection function works really well https://github.com/egoist/style-inject/pull/28/files
Styles are loaded via SSR with different
idattributes. This will only run ifstyleIdis specified.I'm adding this PR because I need the id to be the same for server + client so I need it at the vite level.
closes #111