Http support #281

jamesalbert · 2019-06-18T09:07:58Z

Just want to say I've had a lot of fun with gravity 😄

I created an issue #280 about adding http support. I'm still unsure if this is wanted at this point in the project. With feedback, I'd be happy to refactor this janky pr a bit and implement the rest for an mvp. Or you can tell me my code sucks and to go home.

I've been testing using a basic flask server and the following gravity script:

func main() {
    var get_tests = [
        [
            "host": "https://reddit.com"
        ],
        [
            "host": "https://api.github.com",
            "path": "/users/jamesalbert"
        ],
        [
            "host": "https://httpbin.org",
            "path": "/get"
        ]
    ]

    get_tests.loop(func (request) {
        var resp = Http.get(request)
        System.print("=== " + resp.Hostname)
        System.print(resp)
    })

    var post_tests = [
        [
            "host": "https://httpbin.org/post",
            "path": "/post",
            "data": [
                "pet": "cat"
            ]
        ]
    ]

    post_tests.loop(func (request) {
        var resp = Http.post(request)
        System.print("=== " + resp.Hostname)
        System.print(resp)
    })
}

jamesalbert · 2019-06-18T09:11:11Z

src/shared/gravity_value.c

@@ -2252,12 +2351,23 @@ inline gravity_string_t *gravity_string_new (gravity_vm *vm, char *s, uint32_t l
    obj->s = (char *)s;
    obj->len = len;
    obj->alloc = (alloc) ? alloc : len;
+    obj->s = mem_alloc(NULL, obj->alloc);


this was needed to concat, unsure of the consequences

marcobambini

Please check my reviews

marcobambini · 2019-06-18T12:37:28Z

src/shared/gravity_hash.c

@@ -174,6 +174,21 @@ gravity_hash_t *gravity_hash_create (uint32_t size, gravity_hash_compute_fn comp
    return hashtable;
 }

+gravity_hash_t *gravity_hash_create_from (gravity_hash_t *from_hash) {


gravity_hash_dup would probably be a better name

marcobambini · 2019-06-18T12:40:43Z

src/shared/gravity_value.c

+    assert(0);
+}
+
+char *gravity_map_to_string(gravity_vm *vm, gravity_map_t *map) {


Why not to reuse convert_map2string defined in gravity_core.c?

marcobambini · 2019-06-18T12:41:02Z

src/shared/gravity_value.c

+    return map_string->s;
+}
+
+gravity_value_t gravity_map_to_value (gravity_vm *vm, gravity_map_t *map) {


Not sure to understand the use case of this...

@marcobambini Wouldn't you say there's a need for _to_value functions for all types? E.g. if I want to create a map with a key associated to an array, I'd have no way of doing that without doing something like:

gravity_map_t *response = gravity_map_new(vm, 32); gravity_list_t *headers = gravity_list_new(vm, 32); gravity_map_insert(vm, response, gravity_string_to_value("Headers"), gravity_list_to_value(headers));

If there's a way for already doing something like this, let me know. I'm cleaning up the implementation at the moment, currently trying to get something like this going

I use the map_to_value method in a similar fashion in src/optionals/gravity_http.c

Oh I guess VALUE_FROM_OBJECT might be helpful in this case 😎

marcobambini · 2019-06-18T12:41:46Z

src/shared/gravity_value.c

    if (s && len) obj->hash = gravity_hash_compute_buffer((const char *)s, len);

    if (vm) gravity_vm_transfer(vm, (gravity_object_t*) obj);
    return obj;
 }

+inline void gravity_string_concat_cstring (gravity_vm *vm, gravity_string_t *obj, char *cstring) {
+    uint32_t len = (uint32_t)(strlen(obj->s) + strlen(cstring));


obj->len would be much better than strlen(obj->s)

marcobambini · 2019-06-18T12:43:02Z

src/shared/gravity_value.c

+inline void gravity_string_concat_cstring (gravity_vm *vm, gravity_string_t *obj, char *cstring) {
+    uint32_t len = (uint32_t)(strlen(obj->s) + strlen(cstring));
+    uint32_t alloc = MAXNUM(len+1, DEFAULT_MINSTRING_SIZE);
+    obj->s = mem_realloc(NULL, obj->s, alloc);


Instead of always perform a men_realloc you should first check if (obj->alloc - obj->len) is big enough

marcobambini · 2019-06-18T12:44:00Z

src/shared/gravity_value.c

+    obj->s = mem_realloc(NULL, obj->s, alloc);
+    obj->len = len;
+    obj->alloc = alloc;
+    strcat(obj->s, cstring);


memcpy would be faster (you already have the right pointer by using (obj->s + obj->len)

marcobambini · 2019-06-18T12:45:36Z

Thanks @jamesalbert for your work on Gravity!

jamesalbert · 2019-06-18T16:39:58Z

Awesome @marcobambini I'll try and tackle these after work. Np, it's a nice little language, I like the style

marcobambini · 2019-06-18T20:08:29Z

Thanks @jamesalbert and please note that a unit test would be recommended.

jamesalbert · 2019-06-22T19:34:15Z

@marcobambini I figured an http client without ssl support is pretty useless. I added openssl support and tried to make it as non-dependent as possible. If the user doesn't have openssl, they can set the optional make parameter OPENSSL_ENABLED to false. I only have my macbook (with openssl) to my disposal, so I added some docker to build and run the example (1 container with openssl, 1 without). All 3 environments are building for me, but I'm sure there's more we can do.

Let me know what you think. You can run the examples in docker with make docker

marcobambini · 2019-09-08T15:43:24Z

@jamesalbert I apologize for taking so long in reviewing your pull request but I made a lot of refactoring for optional classes. Can you please remove the files:
gravity_visualstudio/gravity.vcxproj
gravity_visualstudio/gravity.vcxproj.filters
so I can fix the remaining conflicts and merge your pull request?
Thanks a lot.

hggz · 2023-08-16T01:44:43Z

@marcobambini not sure if this is still possible to be revisited. would it be possible to carry this work through with this pr's changes, if it currently isnt in the main release?

jamesalbert added 2 commits June 17, 2019 00:06

Initial Http implementation

2695e5b

Solidify http a little more (added json post requests)

a5b3b98

jamesalbert commented Jun 18, 2019

View reviewed changes

marcobambini requested changes Jun 18, 2019

View reviewed changes

jamesalbert added 2 commits June 22, 2019 03:28

Refactoring

1a54aae

Add build environment

606a570

Remove example json

f598ef2

marcobambini approved these changes Sep 8, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Http support #281

Http support #281

jamesalbert commented Jun 18, 2019 •

edited

jamesalbert Jun 18, 2019

marcobambini left a comment

marcobambini Jun 18, 2019

marcobambini Jun 18, 2019

marcobambini Jun 18, 2019

jamesalbert Jun 21, 2019 •

edited

jamesalbert Jun 21, 2019 •

edited

jamesalbert Jun 21, 2019

marcobambini Jun 18, 2019

marcobambini Jun 18, 2019

marcobambini Jun 18, 2019

marcobambini commented Jun 18, 2019

jamesalbert commented Jun 18, 2019

marcobambini commented Jun 18, 2019

jamesalbert commented Jun 22, 2019 •

edited

marcobambini commented Sep 8, 2019

hggz commented Aug 16, 2023

Http support #281

Are you sure you want to change the base?

Http support #281

Conversation

jamesalbert commented Jun 18, 2019 • edited

Choose a reason for hiding this comment

marcobambini left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jamesalbert Jun 21, 2019 • edited

Choose a reason for hiding this comment

jamesalbert Jun 21, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marcobambini commented Jun 18, 2019

jamesalbert commented Jun 18, 2019

marcobambini commented Jun 18, 2019

jamesalbert commented Jun 22, 2019 • edited

marcobambini commented Sep 8, 2019

hggz commented Aug 16, 2023

jamesalbert commented Jun 18, 2019 •

edited

jamesalbert Jun 21, 2019 •

edited

jamesalbert Jun 21, 2019 •

edited

jamesalbert commented Jun 22, 2019 •

edited