Merge SetUIElementRequests on the backend #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
akshayka
force-pushed
the
aka/improve-merge-set-ui-elems
branch
from
1d37f91
to
726331c
Compare
mscolnick
approved these changes
May 15, 2024
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.5.3-dev11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves merging of
SetUIElementValueRequestto the backend, eliminating the need model the runtime state machine in the frontend. As a result this PR also eliminates the FE mechanism of registering run starts and run ends, which was error prone.In the backend, this is accomplished by adding a new queue for
SetUIElementValueRequests -- these requests are stored in both the control queue, which determines ordering ofSetUIElementValueRequests relative to other types of control quests, and this new queue. The new queue is just used for batching.An alternative would be to split the control queue into two queues, or even N queues, one for each type of request, and then add a new routing queue that gave the order in which the queues should be pulled from. But that was more work, and kind of overkill ... memory pressure due to copying the
SetUIElementValueRequestis negligible.