Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: seperate worker for saving #1375

Merged
merged 1 commit into from
May 15, 2024
Merged

improvement: seperate worker for saving #1375

merged 1 commit into from
May 15, 2024

Conversation

mscolnick
Copy link
Contributor

@mscolnick mscolnick commented May 14, 2024

This adds a second web-worker for saving. This does add to the overhead since now we need to install pyodide on 2 workers since the python interpreter is not shared between them

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 11:05pm
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 11:05pm

Copy link
Contributor

@akshayka akshayka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. How much overhead does this add? Hopefully it doesn't double the start-up time?

@mscolnick mscolnick merged commit ffe5b97 into main May 15, 2024
28 of 29 checks passed
@mscolnick mscolnick deleted the ms/save-web-worker branch May 15, 2024 12:45
@mscolnick
Copy link
Contributor Author

@akshayka about 2x the heap. but doesn't seem to effect start-up time on my computer

Copy link

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.5.3-dev9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants