Simplify SDP index mapping #98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #98 +/- ##
==========================================
- Coverage 82.26% 81.97% -0.30%
==========================================
Files 12 12
Lines 1269 1254 -15
==========================================
- Hits 1044 1028 -16
- Misses 225 226 +1
☔ View full report in Codecov by Sentry. |
|
The error seems unrelated since I get it in #99 as well |
|
looks good, just have to fix conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was a bit worried at first when reading it because
mapindicescreate columnwise lower-triangular indices while the MOI convention is columnwise upper-triangular.Then it seems that the way it's used just goes back and forth and at it end it just gives the MOI variable indices ? I might be wrong but let's try (I need to get in the plane so no time to test 😆 )