Only use embedded GSL if there is no target "GSL" #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using stduuid with FetchContent/CPM.cmake, and also including GSL with such process, it create a conflict and it then become ambiguous which file is used where. Concrete use case: ```cmake CPMAddPackage( NAME GSL GIT_REPOSITORY "https://github.com/microsoft/GSL" GIT_TAG "v4.0.0" ) CPMAddPackage( NAME stduuid GIT_REPOSITORY "https://github.com/mariusbancila/stduuid" GIT_TAG "master" ) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using stduuid with FetchContent/CPM.cmake/find_package, and also including GSL with such process, it create a conflict and it then become ambiguous which file is used where.
Concrete use case:
For now the workaround is to defined
UUID_USING_CXX20_SPAN, which defeat its meaning.