[brief] Make the installed version number match stduuid version. #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[detailed] - Installed version was still at 1.0 even though library is now at 1.2.3.
[detailed] - CMake expects the file to be named stduuid-config-version.cmake, not stduuid-version.cmake. - This now fully enables support for finding the package by version number.
OlivierLDff
added a commit
to OlivierLDff/nixpkgs
that referenced
this pull request
Apr 27, 2024
stduuid reported the wrong version to cmake, causing `find_package(stduuid 1.2.3)` to fail (but `find_package(stduuid 1.0)` was working which is NOT expected. Patch is from this [PR](mariusbancila/stduuid#79). This will need to be updated if `stduuid` is getting maintained again one day.
OlivierLDff
added a commit
to OlivierLDff/nixpkgs
that referenced
this pull request
Apr 27, 2024
stduuid reported the wrong version to cmake, causing `find_package(stduuid 1.2.3)` to fail (but `find_package(stduuid 1.0)` was working which is NOT expected. Patch is from this [PR](mariusbancila/stduuid#79). This will need to be updated if `stduuid` is getting maintained again one day.
OlivierLDff
added a commit
to OlivierLDff/stduuid
that referenced
this pull request
Apr 29, 2024
* Installed version was still at 1.0 even though library is now at 1.2.3. * This is to keep things up-to-date and to allow users to link against specific versions of stduuid via `find_package(stduuid 1.2.3)` Commit from mariusbancila#79 Co-authored-by: Mauricio A. Rovira Galvez <8482308+marovira@users.noreply.github.com>
OlivierLDff
added a commit
to OlivierLDff/stduuid
that referenced
this pull request
Apr 29, 2024
* Installed version was still at 1.0 even though library is now at 1.2.3. * This is to keep things up-to-date and to allow users to link against specific versions of stduuid via `find_package(stduuid 1.2.3)` Commit from mariusbancila#79 Co-authored-by: Mauricio A. Rovira Galvez <8482308+marovira@users.noreply.github.com>
OlivierLDff
added a commit
to OlivierLDff/nixpkgs
that referenced
this pull request
Apr 29, 2024
stduuid reported the wrong version to cmake, causing `find_package(stduuid 1.2.3)` to fail (but `find_package(stduuid 1.0)` was working which is NOT expected. Patch is from this [PR](mariusbancila/stduuid#79). This will need to be updated if `stduuid` is getting maintained again one day.
OlivierLDff
added a commit
to OlivierLDff/nixpkgs
that referenced
this pull request
Apr 29, 2024
stduuid reported the wrong version to cmake, causing `find_package(stduuid 1.2.3)` to fail (but `find_package(stduuid 1.0)` was working which is NOT expected. Patch is from this [PR](mariusbancila/stduuid#79). This will need to be updated if `stduuid` is getting maintained again one day.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[detailed]
find_package(stduuid 1.2.3)