Add ChartId to Chart to use as CanvasId #192
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new instance of Config is assigned to a Chart component, a new CanvasId is created. This causes Blazor to fail to find the original instance of the component in the DOM.
Solution is to create an ID within the Chart. This ID is invariant for the lifetime of the Chart. When a new Config is assigned to the Chart, the Chart sets the CanvasId to be the same as the ChartId. This ensures that Blazor is able to find the original component in the DOM and update the view as required.
Fixes #180.