Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vite to version 4 #102

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bickelj
Copy link

@bickelj bickelj commented Jan 29, 2023

This resolves a dependency conflict when cloning the previous commit.

This resolves a dependency conflict when cloning the previous commit.
@bickelj
Copy link
Author

bickelj commented Jan 29, 2023

On a fresh clone at cee80ed npm was unhappy (node versions v16.19.0 and v18.12.1):

$ npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @vitejs/plugin-vue@4.0.0
npm ERR! Found: vite@3.1.8
npm ERR! node_modules/vite
npm ERR!   dev vite@"^3.1.8" from the root project
npm ERR!   vite@"^3.0.0 || ^4.0.0" from vitest@0.25.8
npm ERR!   node_modules/vitest
npm ERR!     dev vitest@"^0.25.8" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer vite@"^4.0.0" from @vitejs/plugin-vue@4.0.0
npm ERR! node_modules/@vitejs/plugin-vue
npm ERR!   dev @vitejs/plugin-vue@"^4.0.0" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: vite@4.0.4
npm ERR! node_modules/vite
npm ERR!   peer vite@"^4.0.0" from @vitejs/plugin-vue@4.0.0
npm ERR!   node_modules/@vitejs/plugin-vue
npm ERR!     dev @vitejs/plugin-vue@"^4.0.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Updating to 4.0.4 seems to fix the issue and I can run npm install and also npm run dev successfully.

Aside: thank you for this tool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant