Improves the way the validator displays matches with many possible values #355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
matches
rule has a large number of possible matches (common when validating to make sure that links point to a valid route or that images point to a file that exists) the error message can be extremely verbose. This PR makes it so that when the number of possible values exceeds eight, the validator only lists the first eight explicitly and then indicates how many more potential values are available. This ensures that users don't get giant error messages with hundreds of possible values.The new error message looks like this:
This approach loosely imitates the way that the node.js repl displays long arrays that are printed with
console.log
.