Correctly handle numbers for ordered list items #372
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #371, ensuring that ordered lists are rendered with a
start
attribute that reflects the number of the first item in the list. This is consistent with the behavior described in the CommonMark specification. The PR also introduces a newvalue
attribute on list item AST nodes that captures the list number used for each ordered list item.value
property on the AST nodevalue
attributevalue
attribute to the list item nodelist
node transform function so that when the list is ordered it walks the children, obtains thevalue
attribute of the first child, and uses that as thestart
value passed into the render treestart
attribute in the render treevalue
attribute for ordered list items and falling back to"1"
when it is not presentCloses #371