Fix inconsistency between type libraries for markdown-it and linkify-it #506
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! 馃槃
I was updating apocrypha to the latest version of Markdoc and started running into some type errors:
Turns out, this is because
@types/markdown-it
depends on any version (*
) of@types/linkify-it
, but the latter wasn't reverse-compatible. This patch pins the version of@types/linkify-it
to the one which is compatible with the the version of the actualmarkdown-it
library that Markdoc uses.Let me know if you have any questions or need more info!