-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected paths to node_modules folder used by benchmark #971
Conversation
…tributing docs for benchmark
Use Line 28 in 8470eb6
|
@puzrin after running |
Did you try from the project root, as |
Ok. The current PR is incorrect because benchmarked versions should be installed in the standalone directory as it is now. Probably, something Windows-specific. Unfortunately, can not test Windows now. I'd suggest creating a new issue for the record or creating a new PR, without the intended paths change. |
BTW, last screenshot says can not find |
I have created a new issue as instructed. Yes, I also tried installing all dependencies using |
Closes #970
Code changes:
Screenshot of
./benchmark/benchmark.js
successfully running after the fix: