Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add options to demo page #1242

Closed
wants to merge 1 commit into from
Closed

[WIP] add options to demo page #1242

wants to merge 1 commit into from

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Apr 25, 2018

Description

Adds options to the demo page so users can set the gfm, pedantic, or smartypants options

image

The question mark next to the spec links to the spec they selected.

The question mark next to smartypants links to the smartypants docs

Also adds the marked version to the title

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@styfle styfle added the category: docs Documentation changes label Jul 14, 2018
@styfle
Copy link
Member

styfle commented Jul 14, 2018

@UziTech What's left to do for this one?

@UziTech
Copy link
Member Author

UziTech commented Jul 15, 2018

I wanted to figure out a way to add all the options without just crowding the top with check boxes but haven't had time to work on it

@styfle
Copy link
Member

styfle commented Jul 15, 2018

Maybe a solution could be to expose the default options as JSON and let the user edit as text? That way the demo is always configurable, even when we add a new option.

@UziTech
Copy link
Member Author

UziTech commented Jul 15, 2018

That sounds good. Should I add a drop-down pane for options?

@styfle
Copy link
Member

styfle commented Jul 15, 2018

Sure

@UziTech
Copy link
Member Author

UziTech commented Oct 19, 2018

closed by #1357

@UziTech UziTech closed this Oct 19, 2018
@UziTech UziTech deleted the demo-options branch February 19, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants