Skip to content
This repository has been archived by the owner on Sep 24, 2018. It is now read-only.

fix infinite loading #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix infinite loading #18

wants to merge 1 commit into from

Conversation

ptcc
Copy link

@ptcc ptcc commented May 23, 2018

fixes #17

@ptcc ptcc closed this May 24, 2018
@ptcc ptcc reopened this May 24, 2018
@fzaninotto
Copy link
Member

I fail to see how that fixes the issue, can you elaborate on the solution?

@ptcc
Copy link
Author

ptcc commented May 25, 2018

by moving the put of FETCH_START inside the try/catch block we ensure that FETCH_CANCEL will still be dispatched if the saga is canceled after the FETCH_START put and before the response = yield call(restClient, restType, meta.resource, payload);

(and that is exactly where it gets canceled in the case described in the issue)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite Loading
3 participants