Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Deprecated findDOMNode" warning in StrictMode #6398

Merged
merged 2 commits into from Jun 28, 2021
Merged

Fix "Deprecated findDOMNode" warning in StrictMode #6398

merged 2 commits into from Jun 28, 2021

Conversation

fzaninotto
Copy link
Member

Closes #4577

@fzaninotto fzaninotto added the RFR Ready For Review label Jun 28, 2021
djhi
djhi approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

@djhi djhi added this to the 3.16.5 milestone Jun 28, 2021
@djhi djhi merged commit d3b3f88 into master Jun 28, 2021
@djhi djhi deleted the Fix-deprecatedDomNode-warnings-in-strict-mode branch June 28, 2021 15:53
@hichemfantar
Copy link

Was this fixed by disabling strict mode?
Are you sure this is the best way to go about this?

@fzaninotto
Copy link
Member Author

Are you sure you read the diff correctly?

@hichemfantar
Copy link

hichemfantar commented Jul 27, 2021 •
edited

I just took a second a look at it and apparently I read it the other way around. I guess I need some rest, thanks for letting me know.
Now from what I read you disabled the warning in dev mode by using unstable_createMuiStrictModeTheme instead of createMuiTheme but you kept createMuiTheme in production.
From my understanding, the "Deprecated findDOMNode" warning doesn't appear in production. Is that correct?

@fzaninotto
Copy link
Member Author

The problem (and the solution) come from material ui. As explained in the code, if you want to understand the solution, check the link mui/material-ui#13394.

@hichemfantar
Copy link

Thanks, I understand now the problem pretty well now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.16.5
Development

Successfully merging this pull request may close these issues.

Deprecated findDOMNode warning in StrictMode - originating from react-transition-group
3 participants
@fzaninotto @hichemfantar @djhi