Fix <ArrayInput> adds previously removed item
#8029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Aug 3, 2022
| label="CustomLabel" | ||
| defaultValue="default@marmelab.com" | ||
| /> | ||
| </SimpleFormIterator> |
There was a problem hiding this comment.
could you also include an input with no default value?
| ); | ||
|
|
||
| // add field and call the onClick event of the button passed as addButton prop |
There was a problem hiding this comment.
Why did you remove this part?
There was a problem hiding this comment.
Because it was unnecessary and actually induced an issue by adding an item twice
There was a problem hiding this comment.
I think it'll break in the case where the developer passed a custom add button. If there is a double add, you should probably remove the one in AddItemButton instead.
fzaninotto
approved these changes
Aug 3, 2022
fzaninotto
requested changes
Aug 3, 2022
| ); | ||
|
|
||
| // add field and call the onClick event of the button passed as addButton prop |
There was a problem hiding this comment.
I think it'll break in the case where the developer passed a custom add button. If there is a double add, you should probably remove the one in AddItemButton instead.
antoinefricker
approved these changes
Aug 3, 2022
fzaninotto
approved these changes
Aug 4, 2022
fzaninotto
changed the title
<ArrayInput> adds previously removed item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7385