Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TypeScript] Fix MenuItemLink prop type isn't exported #8040

Merged
merged 1 commit into from Aug 5, 2022
Merged

[TypeScript] Fix MenuItemLink prop type isn't exported #8040

merged 1 commit into from Aug 5, 2022

Conversation

fzaninotto
Copy link
Member

When trying to export a component based on MenuItemLink, TypeScript complains with:

Exported variable 'MenuItemLink' has or is using name 'Props$1' from external module 'a/file/path/node_modules/ra-ui-materialui/dist/index' but cannot be named. ts(4023)

I believe this is due to the React.forwardRef not being properly typed in that component.

@fzaninotto fzaninotto added the RFR Ready For Review label Aug 4, 2022
@fzaninotto fzaninotto merged commit 0ae5f1f into master Aug 5, 2022
@fzaninotto fzaninotto deleted the fix-MenuItemLink-type branch August 5, 2022 10:09
@fzaninotto fzaninotto added this to the 4.2.6 milestone Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arimet arimet arimet approved these changes

@antoinefricker antoinefricker antoinefricker approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.2.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fzaninotto @arimet @antoinefricker