Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Puppeteer arguments #210

Merged
merged 3 commits into from Feb 25, 2020
Merged

Refactor Puppeteer arguments #210

merged 3 commits into from Feb 25, 2020

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Feb 25, 2020

Marp CLI had overridden the argument for disabling BGPT, to enable BGPT forcibly (Enabling BGPT prevents glitched rendering of slide: #78). However, Puppeteer >= v2.1.0 does no longer disable BlinkGenPropertyTrees.

I've refactored src/utils/puppeteer.ts to follow the default argument.

@yhatt yhatt merged commit 08b9c4e into master Feb 25, 2020
@yhatt yhatt deleted the puppeteer-args-bgpt branch February 25, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant