Draft: params.clones

[fratzinger]

• feat(findInStore): add params.clones
• feat: findInStore with params.clones
• feat: getFromStore with params.clones
• fix(findInStore): don't readd picked values
• refactor(findInStore): move _.values to items / temps getters -> micro perf
• refactor: simplify addOrUpdate
• docs: add params.clones
• tests
• fix: add idField to getAnyId
• feat: add micro-optimization getters (itemsAndTemps, itemsAndClones, itemsTempsAndClones, operators)
• perf: findInStore micro-optimized
• fix: model.reset() working again
• add resetClone renaming to the 'What's Different from Feathers-Vuex' section
• add a test for clone.reset() @fratzinger
• add new getters to docs
• add clone.clone() to the 'What's Different from Feathers-Vuex' section

Because feathers-pinia uses clones over copies consistently, I decided to call it params.clones. It's a (small) breaking change compared to feathers-vuex.

Also I also added variable pickedValues because otherwise if $select is used, the items get added and added to the store. That's also problematic for clones, because the cloned $selected values would overwrite the itemsById values. I'm happy to discuss this.

closes #30

[marshallswain]

This is looking solid. Could you add some tests to make the spec official?

[fratzinger]

Currently at it ;)

[fratzinger]

I think it's ready now. I also added params.clones support for getFromStore. This diverges from findInStore a little bit.
In findInStore we have temps: true and clones: true. In getFromStore we don't have temps: true. Instead we can use getFromStore(__tempId).
So there are two behaviors:

• findInStore({ query: {}, temps: false, clones: true } returns just items with id and and if existent, their cloned items
• For getInStore there no option to set temps: false

Maybe we can just leave it like that. Maybe we should add support for temps: false for getFromStore.

[fratzinger]

We could even do more micro optimizations, if we have a itemsAndTemps, itemsWithClones, itemsAndTempsWithClones store getters. In findInStore we could use:

let values
if (!params.temps && !params.clones) {
  values = this.items
} else if (params.temps && !params.clones) {
  values = this.itemsAndTemps
} else if (!params.temps && params.clones) {
  values = this.itemsWithClones
} else {
  values = this.itemsAndTempsWithClones
}

The more a findInStore is used with temps or clones, the more the micro optimization pays off because the concatenation of items, temps and clones is cached.
What do you think?

[marshallswain]

I like it.  Let’s call them itemsAndTemps itemsAndClones itemsTempsAndClones

[fratzinger]

Started it and went down the rabbit hole in #30. Need decisions first over there (see the todos at the bottom of the issue). When decisions are clear, I'll add the other todos to this PR.

[fratzinger]

Reason for #30 was a failing test. I don't know what to do. There is a quirk about __isClone being false and undefined. Please @marshallswain could you have a look?:

• test: https://github.com/fratzinger/feathers-pinia/blob/2d4d66ac04e86291535d38038ad878c13c0bd79d/tests/lists.test.ts#L104-L125
• test result: https://github.com/marshallswain/feathers-pinia/runs/4908931477?check_suite_focus=true

[marshallswain]

@fratzinger, I'm still open to adding this feature. Since this PR is so far outdated, now, I'm going to go ahead and close it and we can re-branch from v2.

[marshallswain]

I went ahead and added the querying part of the feature through findInStore and getFromStore: https://github.com/marshallswain/feathers-pinia/releases/tag/v2.0.0-pre.11