Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #10

Merged
merged 45 commits into from May 27, 2021
Merged

Upgrade dependencies #10

merged 45 commits into from May 27, 2021

Conversation

xeptore
Copy link
Contributor

@xeptore xeptore commented Apr 1, 2021

Upgrade all dependencies to their latest version.

Closes #4.

migrate eslint prettier plugin and configuration plugin configuration due to breaking changes
lint all files by executing 'lint' npm script
it contains all TypeScript type declarations for commitlint package types
initialize husky to install git commit hooks in prepare script
@martinmcwhorter
Copy link
Owner

It looks like tests failed in relation to full-stop.

I think commitlint used to require a provided full-stop char, but then they removed that param. If I remember right.

@xeptore
Copy link
Contributor Author

xeptore commented Apr 1, 2021

About the failing tests, there is a bug I found in some rule configuration type declarations of @commitlint/types package. I made a PR yesterday that fixes this bug here: conventional-changelog/commitlint#2534, and at the time of writing this, it seems it will be accepted and possibly merged soon.

@xeptore xeptore closed this Apr 1, 2021
@xeptore xeptore reopened this Apr 1, 2021
@xeptore xeptore marked this pull request as draft April 9, 2021 11:01
typescript 4.2.3 => 4.2.4
tslib 2.1.0 => 2.2.0
@typescript-eslint/eslint-plugin 4.20.0 => 4.21.0
@typescript-eslint/parser 4.20.0 => 4.21.0
@commitlint/cli 12.0.1 =>  12.1.1
@commitlint/config-conventional 12.0.1 =>  12.1.1
@commitlint/load 12.0.1 =>  12.1.1
@commitlint/types 12.0.1 =>  12.1.1
@xeptore
Copy link
Contributor Author

xeptore commented Apr 9, 2021

conventional-changelog/commitlint#2534 has been merged. Waiting for the new version publish to update our dependencies.

@martinmcwhorter
Copy link
Owner

martinmcwhorter commented May 27, 2021

@xeptore I believe the changes you made to commitlint have been released. Can you update this PR with an updated commitlint version?

@xeptore xeptore marked this pull request as ready for review May 27, 2021 16:41
@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #10 (b9ce146) into master (c3f8172) will increase coverage by 0.44%.
The diff coverage is 85.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   79.03%   79.47%   +0.44%     
==========================================
  Files          12       12              
  Lines         372      380       +8     
  Branches       77       88      +11     
==========================================
+ Hits          294      302       +8     
+ Misses         78       77       -1     
- Partials        0        1       +1     
Flag Coverage Δ
unittests 79.47% <85.55%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/engine.ts 0.00% <0.00%> (ø)
src/index.ts 0.00% <0.00%> (ø)
src/prompts/footer-maker.ts 0.00% <0.00%> (ø)
src/commit-template.ts 100.00% <100.00%> (ø)
src/filters.ts 100.00% <100.00%> (ø)
src/prompts/body-maker.ts 100.00% <100.00%> (ø)
src/prompts/scope-maker.ts 97.77% <100.00%> (+0.05%) ⬆️
src/prompts/subject-maker.ts 100.00% <100.00%> (ø)
src/prompts/type-maker.ts 100.00% <100.00%> (ø)
src/utils.ts 100.00% <100.00%> (ø)
... and 2 more

@xeptore
Copy link
Contributor Author

xeptore commented May 27, 2021

@martinmcwhorter, all outdated dependencies, including commitlint were updated. It seems it is a bad credential error that causes the Node.js CI job to fail, and everything else is working fine.

@martinmcwhorter martinmcwhorter merged commit fbde556 into martinmcwhorter:master May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package lock dependencies
2 participants