Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "-Wundef" warning when building as C++20 #85

Closed
wants to merge 1 commit into from
Closed

Fix "-Wundef" warning when building as C++20 #85

wants to merge 1 commit into from

Commits on May 6, 2024

  1. Fix "-Wundef" warning when building as C++20 

    When including `span.hpp` in a source file compiled as C++20, I get an
error similar to this:

    $ g++ -x c++-header span.hpp -Wundef -Werror -std=c++20
    span.hpp:43:33: error: "span_HAVE_STRUCT_BINDING" is not defined, evaluates to 0 [-Werror=undef]
       43 | #define span_HAVE( feature )  ( span_HAVE_##feature )
          |                                 ^~~~~~~~~~
    span.hpp:1873:5: note: in expansion of macro ‘span_HAVE’
     1873 | #if span_HAVE( STRUCT_BINDING )
          |     ^~~~~~~~~

Fix it by checking if `span_HAVE_STRUCT_BINDING` is defined.
Unfortunately, I couldn't find a way to make `defined()` work with
`span_HAVE( STRUCT_BINDING )`.

An alternative would be to move the definition of
`span_HAVE_STRUCT_BINDING` outside of the `span_USES_STD_SPAN` ifdef.

Fixes martinmoene#84.

Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
    @simark
    simark committed May 6, 2024
    Configuration menu
    Copy the full SHA
    6a5024b View commit details
    Browse the repository at this point in the history