Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example configuration for IDEA as a merge tool #3614

Closed

Conversation

HybridEidolon
Copy link
Contributor

Adds an additional example configuration for IntelliJ IDEA alongside kdiff3 and vimdiff.

Checklist

If applicable:

  • I have updated the documentation (README.md, docs/, demos/)

Adds an additional example configuration for IntelliJ IDEA alongside
kdiff3 and vimdiff.
@ilyagr
Copy link
Collaborator

ilyagr commented May 2, 2024

I put a few more details in https://github.com/martinvonz/jj/wiki/Jetbrains-IntelliJ-IDEs earlier, though I'm not sure it's easy for people to find.

I think we could link that wiki from config.md. Alternatively, if we had a predefined config like you sugest, we'd want to mention it there, and explain that the user will probably have to change the program field.

@@ -547,6 +547,10 @@ merge-tools.vimdiff.merge-args = ["-f", "-d", "$output", "-M",
"-c", "set write"]
merge-tools.vimdiff.program = "vim"
merge-tools.vimdiff.merge-tool-edits-conflict-markers = true # See below for an explanation

# For IntelliJ IDEA or other JetBrains products on macOS
merge-tools.idea.program = "/Applications/IntelliJ IDEA.app/Contents/MacOS/idea"
Copy link
Collaborator

@Cretezy Cretezy May 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add a note that for Linux, the launcher script is just idea (if on PATH, which is should be by default) after it's installed: https://www.jetbrains.com/help/idea/working-with-the-ide-features-from-command-line.html

@HybridEidolon
Copy link
Contributor Author

Given that there is a wiki for things like this, maybe this doesn't need to go into the documentation? I wasn't aware the github wiki had anything on it.

@ilyagr
Copy link
Collaborator

ilyagr commented May 14, 2024

I don't think this should go into the documentation as-is. If anything, we could change the documentation to make the wiki easier to discover. (E.g. a mention that there is a config for IDEA there).

@HybridEidolon HybridEidolon deleted the push-puqtlysvxxno branch May 14, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants