Propagate errors from Commit::parents() and Commit::predecessors()
#3625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilipMetzger
approved these changes
May 5, 2024
yuja
reviewed
May 6, 2024
martinvonz
force-pushed
the
push-qzuokysnzyqk
branch
2 times, most recently
from
5f05d94
to
2230910
Compare
martinvonz
force-pushed
the
push-qzuokysnzyqk
branch
from
2230910
to
d73fe9d
Compare
The function now returns an iterator over `Result`s, matching `Operation::parents()`. I updated callers to also propagate the error where it was trivial.
martinvonz
force-pushed
the
push-qzuokysnzyqk
branch
from
d73fe9d
to
ed6f65d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md