feature: support experimental .sass\.scss #69
Conversation
| // Hack our way to disable errors on node_modules CSS modules | ||
| const nextErrorCssLoader = nextCssLoaders.oneOf.find( | ||
| (rule) => rule.use && rule.use.loader === 'error-loader' && regexEqual(rule.test, /\.module\.css$/) | ||
| (rule) => rule.use && rule.use.loader === 'error-loader' && (Array.isArray(rule.test) ? regexEqual(rule.test[0], /\.module\.css$/) : regexEqual(rule.test, /\.module\.css$/)) |
There was a problem hiding this comment.
the [0] should be avoided imo, if we can find a more dynamic way to do it, that'd be great
There was a problem hiding this comment.
It is either one regexp, that catches .module.css, or array of regexps, one of which captures it.
Either way function will be long if it would be written in such way. Probably that part of code should be written with ifs to be more readable.
There was a problem hiding this comment.
Other way is to do
rule.some((regex) => regexEqual(regex, /\.module\.css$/))
Sadly i have no idea how to do e2e/integration tests. |
Everything is already setup, you just have to add tests about the features that are supported by Next.js. Could be something like that:
Some inspiration: |
|
Well it depends on canary version of next. Should we wait till 9.3? vercel/next.js#10571 according to that PR sass is not experimental anymore |
|
You have two options here 😄
Your move ;) |
|
Closing in favor of #74 |
This will fix #66