Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 24bit TrueColor #30

Merged
merged 1 commit into from Apr 22, 2023
Merged

Add support for 24bit TrueColor #30

merged 1 commit into from Apr 22, 2023

Conversation

marvinhagemeister
Copy link
Owner

Fixes #29

@changeset-bot
Copy link

changeset-bot bot commented Apr 22, 2023

🦋 Changeset detected

Latest commit: 737ef18

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
kolorist Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment on lines +56 to +59
// Windows supports 24bit True Colors since Windows 10 revision #14931,
// see https://devblogs.microsoft.com/commandline/24-bit-color-in-the-windows-console/
if (process.platform === 'win32') {
supportLevel = SupportLevel.trueColor;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't realize that, TIL!

Copy link

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great for my original issue and true color support is really cool! Thanks!

@marvinhagemeister marvinhagemeister merged commit dee59f2 into main Apr 22, 2023
1 check passed
@marvinhagemeister marvinhagemeister deleted the truecolor branch April 22, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Better 256 color detection
2 participants