Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DP-26913: Fixes running BackstopJS locally in DDEV, updates documentation, and adds a CircleCI job to capture screenshots nightly #1852

Merged
merged 45 commits into from
Feb 28, 2023

Conversation

justafish
Copy link
Contributor

@justafish justafish commented Jan 24, 2023

Description:

  • Adds a DDEV command to allow BackstopJS to be run locally
  • Increases shm_size to 2gb to avoid the browser crashing inside a docker container. See https://bugs.chromium.org/p/chromium/issues/detail?id=519952 and https://github.com/SeleniumHQ/docker-selenium#--shm-size2g
  • Switches CircleCI to using backstop's provided image
  • Updated the documentation and adds instructions for running the backstop job using CircleCI's local CLI
  • Adds a CircleCI job which collects Backstop reference images nightly and stores them as an artifact
  • Adds an additional backstop test during the deploy_cd CirlceCI job which uses reference images from the above job

Jira: (Skip unless you are MA staff)
DP-26913

To Test:

  • Follow the instructions in the README for running things locally
  • Verify examples running in CircleCI for the reference and test jobs from earlier in this PR
  • Run ddev drush ma:ci:backstop-snapshot prod --ci-branch=dp-26913-run-backstop-js-locally successfully (this might take a few tries as production still has timeout issues trying to gather reference images)
  • Run ddev drush ma:ci:backstop-compare --reference=prod --target=test --ci-branch=dp-26913-run-backstop-js-locally to test against the newly generated reference images

Peer Review Checklist

@massgov-bot massgov-bot temporarily deployed to Tugboat January 24, 2023 17:58 Destroyed
@massgov-bot massgov-bot temporarily deployed to Tugboat January 25, 2023 23:07 Destroyed
@massgov-bot massgov-bot temporarily deployed to Tugboat January 30, 2023 00:52 Destroyed
@justafish justafish marked this pull request as draft January 30, 2023 00:52
@massgov-bot massgov-bot temporarily deployed to Tugboat January 30, 2023 01:04 Destroyed
@massgov-bot massgov-bot temporarily deployed to Tugboat January 30, 2023 04:00 Destroyed
@massgov-bot massgov-bot temporarily deployed to Tugboat January 30, 2023 05:13 Destroyed
@massgov-bot massgov-bot temporarily deployed to Tugboat January 30, 2023 06:52 Destroyed
@massgov-bot massgov-bot temporarily deployed to Tugboat January 30, 2023 07:00 Destroyed
@massgov-bot massgov-bot temporarily deployed to Tugboat January 30, 2023 09:06 Destroyed
@massgov-bot massgov-bot temporarily deployed to Tugboat January 30, 2023 09:23 Destroyed
@massgov-bot massgov-bot temporarily deployed to Tugboat January 30, 2023 09:45 Destroyed
@massgov-bot massgov-bot temporarily deployed to Tugboat February 21, 2023 15:19 Destroyed
@massgov-bot massgov-bot temporarily deployed to Tugboat February 21, 2023 17:58 Destroyed
@massgov-bot massgov-bot temporarily deployed to Tugboat February 21, 2023 17:59 Destroyed
@massgov-bot massgov-bot temporarily deployed to Tugboat February 21, 2023 18:02 Destroyed
@massgov-bot massgov-bot temporarily deployed to Tugboat February 21, 2023 18:09 Destroyed
@massgov-bot massgov-bot temporarily deployed to Tugboat February 21, 2023 18:16 Destroyed
@massgov-bot massgov-bot temporarily deployed to Tugboat February 23, 2023 17:47 Destroyed
Copy link
Contributor

@weitzman weitzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good to me. I'm OK with merging this now, or waiting for the cache bust bypass to be added.

backstop/README.md Outdated Show resolved Hide resolved
backstop/README.md Outdated Show resolved Hide resolved
justafish and others added 2 commits February 27, 2023 15:35
Co-authored-by: Moshe Weitzman <weitzman@tejasa.com>
Co-authored-by: Moshe Weitzman <weitzman@tejasa.com>
@massgov-bot massgov-bot temporarily deployed to Tugboat February 27, 2023 15:35 Destroyed
@massgov-bot massgov-bot temporarily deployed to Tugboat February 27, 2023 15:35 Destroyed
@massgov-bot massgov-bot temporarily deployed to Tugboat February 27, 2023 15:36 Destroyed
@massgov-bot massgov-bot temporarily deployed to Tugboat February 28, 2023 04:24 Destroyed
@justafish justafish merged commit 49684a5 into develop Feb 28, 2023
@justafish justafish deleted the dp-26913-run-backstop-js-locally branch February 28, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants