-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change older Paperclip database migrations for consistency #30204
Conversation
Is the idea here to focus more narrowly on the schema/migration disconnect (by restoring old migrations to their original output), and either not bother with, or at least skip for now, the bigint solution to the potential size issue? |
What potential size issues are you referring to? |
Sorry, I just meant that there were sort of two issues dealt with in the migrations:
So I was asking if the plan here is to deal with the first issue by changing the old migrations, and ignore the file size storage issue (maybe this is OK ... I think it's a ~2GB size where you hit the limit, which is well above the default limits for these attachments...) |
Yes, I don't think we have a need to go to |
Cool - in that case I agree with the already done revert, and with this approach to aligning the old migrations with the schema. |
@ClearlyClaire @mjankowski Is this not applied to Backup? Just for confirmation. |
The |
Oh, That's fine... |
First part of an alternative to #29263, as discussed in #30203 (comment)
cc @mjankowski