Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests for JavaScript #3496

Merged
merged 1 commit into from
Jun 1, 2017
Merged

Improve tests for JavaScript #3496

merged 1 commit into from
Jun 1, 2017

Conversation

ykzts
Copy link
Sponsor Member

@ykzts ykzts commented Jun 1, 2017

  • Upgrade dependencies
    • chai (3.5.0 -> 4.0.1)
    • chai-enzyme (0.6.1 -> 0.7.1)
    • sinon (2.2.0 -> 2.3.2)
  • Change extensions from .jsx to .js
  • Don't assign React to global
  • Check code format using ESLint

@ykzts
Improve tests for JavaScript
803e672 
- Upgrade dependencies
    - chai (3.5.0 -> 4.0.1)
    - chai-enzyme (0.6.1 -> 0.7.1)
    - sinon (2.2.0 -> 2.3.2)
- Change extensions from .jsx to .js
- Don't assign `React` to `global`
- Check code format using ESLint
ykzts
ykzts commented Jun 1, 2017
View reviewed changes
package.json
@@ -116,8 +116,8 @@
"devDependencies": {
"@kadira/storybook": "^2.35.3",
"babel-eslint": "^7.2.3",
"chai": "^3.5.0",
"chai-enzyme": "^0.6.1",
"chai": "^4.0.1",
Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/chaijs/chai/releases/tag/4.0.0

Breaking Changes

We no longer support Node v0.10 and v0.12 (since their LTS has ended) (PRs: #816, #901)

...

Other changes are unrelated changes to Mastodon.

@Gargron Gargron merged commit 39ea5c0 into mastodon:master Jun 1, 2017
@ykzts ykzts deleted the improve-js-tests branch June 1, 2017 15:27
koteitan pushed a commit to koteitan/mastodon that referenced this pull request Jun 25, 2017
@ykzts @koteitan
Improve tests for JavaScript (mastodon#3496)
5578cd9 
- Upgrade dependencies
    - chai (3.5.0 -> 4.0.1)
    - chai-enzyme (0.6.1 -> 0.7.1)
    - sinon (2.2.0 -> 2.3.2)
- Change extensions from .jsx to .js
- Don't assign `React` to `global`
- Check code format using ESLint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abcang abcang abcang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ykzts @abcang @Gargron