Upgrade to Webpack 3 with module concatenation #3912
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the size of
application.js
from 670196 bytes to 655404 bytes (14.8kB saved). The other bundles are roughly the same size as before.You can read more about how module concatenation (aka scope hoisting) works here. Essentially this will just take all of our modules inside of
application.js
and squash them into a single function scope instead of having multiplefunction(){}
wrappers around each one. It de-penalizes us for having multiple small modules.Interestingly this actually increases the gzip size of
application.js
slightly (171181 to 173646, 2.46kB) but I think the tradeoff is worth it given that the ungzipped size is what the browser has to parse, and less JS to parse is always good.