[Badge] Prevent multiple badges being attached to a menu item at the …

…same time

Fixes the logic in NavigationBarMenuView.restoreBadgeDrawables(), which may override the newly created badges with the restored drawables incorrectly. Also adds a safe guard that removes the previously attached badges if any, before attaching a new badge.

PiperOrigin-RevId: 424923078

lib/java/com/google/android/material/navigation/NavigationBarItemView.java

@@ -33,6 +33,7 @@
 import androidx.appcompat.view.menu.MenuView;
 import androidx.appcompat.widget.TooltipCompat;
 import android.text.TextUtils;
+import android.util.Log;
 import android.view.Gravity;
 import android.view.LayoutInflater;
 import android.view.View;
@@ -774,6 +775,13 @@ public void setActiveIndicatorResizeable(boolean resizeable) {
   }
 
   void setBadge(@NonNull BadgeDrawable badgeDrawable) {
+    if (this.badgeDrawable == badgeDrawable) {
+      return;
+    }
+    if (hasBadge() && icon != null) {
+      Log.w("NavigationBar", "Multiple badges shouldn't be attached to one item.");
+      tryRemoveBadgeFromAnchor(icon);
+    }
     this.badgeDrawable = badgeDrawable;
     if (icon != null) {
       tryAttachBadgeToAnchor(icon);

lib/java/com/google/android/material/navigation/NavigationBarMenuView.java

@@ -797,7 +797,7 @@ void restoreBadgeDrawables(SparseArray<BadgeDrawable> badgeDrawables) {
     }
     if (buttons != null) {
       for (NavigationBarItemView itemView : buttons) {
-        itemView.setBadge(badgeDrawables.get(itemView.getId()));
+        itemView.setBadge(this.badgeDrawables.get(itemView.getId()));
       }
     }
   }