feat(ripple) mdc-web typescript conversion #711

gugu · 2019-03-01T23:51:01Z

I am stuck with some cryptic typescript error, will fix it tomorrow

UPD: fixed

codecov-io · 2019-03-04T21:07:04Z

Codecov Report

Merging #711 into rc0.11.0 will decrease coverage by 0.15%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##           rc0.11.0   #711      +/-   ##
==========================================
- Coverage     95.16%    95%   -0.16%     
==========================================
  Files            73     73              
  Lines          2914   2922       +8     
  Branches        442    448       +6     
==========================================
+ Hits           2773   2776       +3     
- Misses           46     50       +4     
- Partials         95     96       +1

Impacted Files	Coverage Δ
packages/tab/TabRipple.tsx	`100% <ø> (ø)`	⬆️
packages/ripple/index.tsx	`86.55% <72.72%> (-3.54%)`	⬇️
packages/list/ListItem.tsx	`97.87% <0%> (ø)`	⬆️
packages/drawer/index.tsx	`93.26% <0%> (ø)`	⬆️
packages/text-field/Input.tsx	`96.72% <0%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce10503...42c00a6. Read the comment docs.

packages/icon-button/index.tsx

package.json

packages/ripple/index.tsx

packages/ripple/package.json

test/screenshot/stop.sh

test/unit/ripple/index.test.tsx

packages/tab/TabRipple.tsx

moog16 · 2019-03-11T21:12:49Z

@gugu last comment: https://github.com/material-components/material-components-web-react/pull/711/files#r263426643

Besides that it looks ready to go

packages/ripple/index.tsx

gugu · 2019-03-12T17:13:15Z

done

moog16 · 2019-03-12T17:31:59Z

The build hasn't passed yet, but I think there are some errors when you run npm start.

…ts-web-react into ripple-typescript

moog16 · 2019-03-13T21:56:17Z

@gugu please ping me when this is ready to be reviewed again. Also I opened a floatinglabel PR.

gugu · 2019-03-13T22:26:01Z

@moog16 done

moog16 · 2019-03-14T16:45:16Z

Looks good! Thanks :)

moog16 · 2019-03-15T22:27:11Z

@gugu - return new ClientRect(); is causing me errors. Is this even part of the ES5/ES6 library? Not sure how I didn't catch this before.

commit 14b22bc Author: Matt Goo <mattgoo@google.com> Date: Tue Apr 30 12:06:32 2019 -0700 feat(select): enhanced select (#823) commit b400013 Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 29 14:49:32 2019 -0700 chore: reduce unused deps in package.json (#819) commit beedb23 Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 29 13:43:20 2019 -0700 feat(select): add icon (#825) commit e22ac2a Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 29 13:35:45 2019 -0700 feat(select): add helper text (#824) commit abaa146 Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 29 13:35:16 2019 -0700 feat(select): add option component (#826) commit 7adc12a Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 29 13:11:16 2019 -0700 fix(drawer): add missing foundation import in drawer (#821) commit 7e0f877 Author: Matt Goo <mattgoo@google.com> Date: Fri Apr 26 14:33:40 2019 -0700 feat(menu): add component (#786) commit 509e93e Author: Matt Goo <mattgoo@google.com> Date: Fri Apr 26 09:46:26 2019 -0700 chore(infrastructure): add esmoduleinterop to tsconfig (#818) commit 4dbc8b8 Author: Matt Goo <mattgoo@google.com> Date: Tue Apr 16 15:56:25 2019 -0700 feat(notched-outline): update to v1.1.1 (#806) commit ea15a2a Author: 태재영 <tjy970721@gmail.com> Date: Sat Apr 13 06:50:37 2019 +0900 fix(chips): Fix incorrect ripple effect (#804) commit 7b413df Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 8 13:27:36 2019 -0700 feat(button): update mdc web deps to v1.1.0 (#791) commit 034158c Author: Matt Goo <mattgoo@google.com> Date: Tue Apr 2 17:36:46 2019 -0700 fix: remove .only (#794) commit 74379af Author: Matt Goo <mattgoo@google.com> Date: Tue Apr 2 16:24:45 2019 -0700 fix(list): maintain classes with state.listItemClassNames (#776) BREAKING CHANGE: Removes props.tabbableOnListItemFocus from all the auxiliary components, as it seemed confusing to have this and tabIndex dictate what tabIndex would ultimately be. commit e5b953f Author: Ben McKernan <ben-mckernan@users.noreply.github.com> Date: Tue Apr 2 20:18:03 2019 +0200 fix(icon-button): upgrade to mdc-web v1.1 (#792) commit 9c7bfa7 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Apr 1 23:08:27 2019 +0300 fix(card): upgrade to mdc-web v1.1 (#788) commit bb9e7e4 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Apr 1 20:44:28 2019 +0300 fix(top-app-bar): mdc-web v1 upgrade (#780) commit 37c7269 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Apr 1 20:00:39 2019 +0300 fix(linear-progress): upgrade mdc-web to v1 (#787) commit b6403e6 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Apr 1 19:38:31 2019 +0300 fix(fab): upgrade to mdc-web v1.1 (#790) commit bcda111 Author: Andrii Kostenko <andrey@kostenko.name> Date: Fri Mar 29 21:11:19 2019 +0300 fix(dialog): mdc-web v1 upgrade (#779) commit 8ff8695 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 28 22:32:55 2019 +0300 fix(typography): upgrade to mdc-web v1 (#778) commit 4d6bbc0 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 28 22:15:22 2019 +0300 feat(radio): upgrade to typescript v1 (#777) commit 4f523e3 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 28 22:13:29 2019 +0300 fix(checkbox): upgrade mdc-web to v1 (#769) commit 1a04f3d Author: Matt Goo <mattgoo@google.com> Date: Wed Mar 27 12:39:00 2019 -0700 feat(menu-surface): upgrade to mdc web v1 (#774) commit 44cca84 Author: Andrii Kostenko <andrey@kostenko.name> Date: Wed Mar 27 01:14:18 2019 +0200 feat(switch): upgrade to mdc-web v1 (#757) commit 580c850 Author: Andrii Kostenko <andrey@kostenko.name> Date: Wed Mar 27 01:13:37 2019 +0200 fix(tab-bar): upgrade mdc-web to v1 (#770) commit 45fef89 Author: Matt Goo <mattgoo@google.com> Date: Mon Mar 25 15:27:29 2019 -0700 fix(card): add react-ripple to package json (#773) commit 4e99b4c Author: Matt Goo <mattgoo@google.com> Date: Tue Mar 19 14:10:37 2019 -0700 feat(list): update to MDC Web 1.0.0 (#740) commit 38e9886 Author: Matt Goo <mattgoo@google.com> Date: Tue Mar 19 12:36:06 2019 -0700 feat(floating-label): update mdc web to v1.0.0 (#741) commit dd95b60 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Mar 18 23:38:34 2019 +0200 feat(snackbar): MDC Web v1.0.0 (#755) commit 9b86474 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Mar 18 23:27:39 2019 +0200 fix(tab): mdc-web v1.0.0 upgrade (#748) commit a8c64b5 Author: Lucas Cordeiro <ecdb.lucas@gmail.com> Date: Mon Mar 18 17:46:29 2019 -0300 feat(drawer): add innerRef prop (#749) commit 5f55983 Author: Andrii Kostenko <andrey@kostenko.name> Date: Fri Mar 15 19:05:44 2019 +0200 fix(chips): upgrade mdc-web to v1.0.0 (#750) commit 09cb8a5 Author: Matt Goo <mattgoo@google.com> Date: Fri Mar 15 10:05:03 2019 -0700 fix: classnames@2.2.5 --> classnames@2.2.6 & update imports (#709) commit ae9b421 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 14 20:53:28 2019 +0300 fix(tab-scroller): upgrade mdc-web to 1.0.0 (#743) commit 1b29dd9 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 14 20:32:18 2019 +0300 fix(tab-indicator): upgrade mdc-web to 1.0.0 (#742) commit f966714 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 14 19:45:11 2019 +0300 feat(ripple) mdc-web typescript conversion (#711) commit 0b674f5 Author: Andrii Kostenko <andrey@kostenko.name> Date: Fri Mar 8 23:54:24 2019 +0300 feat(line-ripple): mdc-web typescript support (#716)

* Squashed commit of the following: commit 14b22bc Author: Matt Goo <mattgoo@google.com> Date: Tue Apr 30 12:06:32 2019 -0700 feat(select): enhanced select (#823) commit b400013 Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 29 14:49:32 2019 -0700 chore: reduce unused deps in package.json (#819) commit beedb23 Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 29 13:43:20 2019 -0700 feat(select): add icon (#825) commit e22ac2a Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 29 13:35:45 2019 -0700 feat(select): add helper text (#824) commit abaa146 Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 29 13:35:16 2019 -0700 feat(select): add option component (#826) commit 7adc12a Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 29 13:11:16 2019 -0700 fix(drawer): add missing foundation import in drawer (#821) commit 7e0f877 Author: Matt Goo <mattgoo@google.com> Date: Fri Apr 26 14:33:40 2019 -0700 feat(menu): add component (#786) commit 509e93e Author: Matt Goo <mattgoo@google.com> Date: Fri Apr 26 09:46:26 2019 -0700 chore(infrastructure): add esmoduleinterop to tsconfig (#818) commit 4dbc8b8 Author: Matt Goo <mattgoo@google.com> Date: Tue Apr 16 15:56:25 2019 -0700 feat(notched-outline): update to v1.1.1 (#806) commit ea15a2a Author: 태재영 <tjy970721@gmail.com> Date: Sat Apr 13 06:50:37 2019 +0900 fix(chips): Fix incorrect ripple effect (#804) commit 7b413df Author: Matt Goo <mattgoo@google.com> Date: Mon Apr 8 13:27:36 2019 -0700 feat(button): update mdc web deps to v1.1.0 (#791) commit 034158c Author: Matt Goo <mattgoo@google.com> Date: Tue Apr 2 17:36:46 2019 -0700 fix: remove .only (#794) commit 74379af Author: Matt Goo <mattgoo@google.com> Date: Tue Apr 2 16:24:45 2019 -0700 fix(list): maintain classes with state.listItemClassNames (#776) BREAKING CHANGE: Removes props.tabbableOnListItemFocus from all the auxiliary components, as it seemed confusing to have this and tabIndex dictate what tabIndex would ultimately be. commit e5b953f Author: Ben McKernan <ben-mckernan@users.noreply.github.com> Date: Tue Apr 2 20:18:03 2019 +0200 fix(icon-button): upgrade to mdc-web v1.1 (#792) commit 9c7bfa7 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Apr 1 23:08:27 2019 +0300 fix(card): upgrade to mdc-web v1.1 (#788) commit bb9e7e4 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Apr 1 20:44:28 2019 +0300 fix(top-app-bar): mdc-web v1 upgrade (#780) commit 37c7269 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Apr 1 20:00:39 2019 +0300 fix(linear-progress): upgrade mdc-web to v1 (#787) commit b6403e6 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Apr 1 19:38:31 2019 +0300 fix(fab): upgrade to mdc-web v1.1 (#790) commit bcda111 Author: Andrii Kostenko <andrey@kostenko.name> Date: Fri Mar 29 21:11:19 2019 +0300 fix(dialog): mdc-web v1 upgrade (#779) commit 8ff8695 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 28 22:32:55 2019 +0300 fix(typography): upgrade to mdc-web v1 (#778) commit 4d6bbc0 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 28 22:15:22 2019 +0300 feat(radio): upgrade to typescript v1 (#777) commit 4f523e3 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 28 22:13:29 2019 +0300 fix(checkbox): upgrade mdc-web to v1 (#769) commit 1a04f3d Author: Matt Goo <mattgoo@google.com> Date: Wed Mar 27 12:39:00 2019 -0700 feat(menu-surface): upgrade to mdc web v1 (#774) commit 44cca84 Author: Andrii Kostenko <andrey@kostenko.name> Date: Wed Mar 27 01:14:18 2019 +0200 feat(switch): upgrade to mdc-web v1 (#757) commit 580c850 Author: Andrii Kostenko <andrey@kostenko.name> Date: Wed Mar 27 01:13:37 2019 +0200 fix(tab-bar): upgrade mdc-web to v1 (#770) commit 45fef89 Author: Matt Goo <mattgoo@google.com> Date: Mon Mar 25 15:27:29 2019 -0700 fix(card): add react-ripple to package json (#773) commit 4e99b4c Author: Matt Goo <mattgoo@google.com> Date: Tue Mar 19 14:10:37 2019 -0700 feat(list): update to MDC Web 1.0.0 (#740) commit 38e9886 Author: Matt Goo <mattgoo@google.com> Date: Tue Mar 19 12:36:06 2019 -0700 feat(floating-label): update mdc web to v1.0.0 (#741) commit dd95b60 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Mar 18 23:38:34 2019 +0200 feat(snackbar): MDC Web v1.0.0 (#755) commit 9b86474 Author: Andrii Kostenko <andrey@kostenko.name> Date: Mon Mar 18 23:27:39 2019 +0200 fix(tab): mdc-web v1.0.0 upgrade (#748) commit a8c64b5 Author: Lucas Cordeiro <ecdb.lucas@gmail.com> Date: Mon Mar 18 17:46:29 2019 -0300 feat(drawer): add innerRef prop (#749) commit 5f55983 Author: Andrii Kostenko <andrey@kostenko.name> Date: Fri Mar 15 19:05:44 2019 +0200 fix(chips): upgrade mdc-web to v1.0.0 (#750) commit 09cb8a5 Author: Matt Goo <mattgoo@google.com> Date: Fri Mar 15 10:05:03 2019 -0700 fix: classnames@2.2.5 --> classnames@2.2.6 & update imports (#709) commit ae9b421 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 14 20:53:28 2019 +0300 fix(tab-scroller): upgrade mdc-web to 1.0.0 (#743) commit 1b29dd9 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 14 20:32:18 2019 +0300 fix(tab-indicator): upgrade mdc-web to 1.0.0 (#742) commit f966714 Author: Andrii Kostenko <andrey@kostenko.name> Date: Thu Mar 14 19:45:11 2019 +0300 feat(ripple) mdc-web typescript conversion (#711) commit 0b674f5 Author: Andrii Kostenko <andrey@kostenko.name> Date: Fri Mar 8 23:54:24 2019 +0300 feat(line-ripple): mdc-web typescript support (#716) * feat(text-field): update to v1.1.1 (#812)

gugu added 3 commits March 2, 2019 00:35

WIP ripple

f192417

Merge branch 'base11' into ripple-typescript

dedeb35

feat(ripple): fix types issues

893fbae

gugu changed the title ~~WIP ripple typescript conversion~~ feat(ripple) mdc-web typescript conversion Mar 4, 2019

moog16 suggested changes Mar 7, 2019

View reviewed changes

gugu added 4 commits March 8, 2019 22:05

feat(ripple): fix low-hanging fruits

8c7a5bf

feat(ripple): typescript style fixed, added comments

429e2fa

feat(ripple): Move ref property to the RippledInterface

d4cf165

feat(ripple): move foundation property to the component interface

d3ddb9c

fix(ripple): unbounded type fixed

916765d

moog16 reviewed Mar 12, 2019

View reviewed changes

packages/ripple/index.tsx Outdated Show resolved Hide resolved

feat(ripple): remove default value for disabled

c524abc

googlebot added the cla: yes label Mar 12, 2019

Merge branch 'rc0.11.0' into ripple-typescript

fed4ef4

gugu added 3 commits March 13, 2019 02:17

feat(ripple): test fixed

4193c6b

Merge branch 'ripple-typescript' of github.com:gugu/material-componen…

fd6b875

…ts-web-react into ripple-typescript

feat(ripple): fix tests

34f98ab

feat(ripple): disable default value for disabled prop

42c00a6

moog16 approved these changes Mar 14, 2019

View reviewed changes

moog16 merged commit 743d00c into material-components:rc0.11.0 Mar 14, 2019

moog16 pushed a commit that referenced this pull request Mar 19, 2019

feat(ripple) mdc-web typescript conversion (#711)

8e74fac

moog16 pushed a commit that referenced this pull request Mar 19, 2019

feat(ripple) mdc-web typescript conversion (#711)

e14f309

moog16 pushed a commit that referenced this pull request Mar 25, 2019

feat(ripple) mdc-web typescript conversion (#711)

9ae9b58

moog16 pushed a commit that referenced this pull request Apr 30, 2019

feat(ripple) mdc-web typescript conversion (#711)

f966714

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ripple) mdc-web typescript conversion #711

feat(ripple) mdc-web typescript conversion #711

gugu commented Mar 1, 2019 •

edited

codecov-io commented Mar 4, 2019 •

edited

moog16 commented Mar 11, 2019 •

edited

gugu commented Mar 12, 2019

moog16 commented Mar 12, 2019

moog16 commented Mar 13, 2019

gugu commented Mar 13, 2019

moog16 commented Mar 14, 2019

moog16 commented Mar 15, 2019

feat(ripple) mdc-web typescript conversion #711

feat(ripple) mdc-web typescript conversion #711

Conversation

gugu commented Mar 1, 2019 • edited

codecov-io commented Mar 4, 2019 • edited

Codecov Report

moog16 commented Mar 11, 2019 • edited

gugu commented Mar 12, 2019

moog16 commented Mar 12, 2019

moog16 commented Mar 13, 2019

gugu commented Mar 13, 2019

moog16 commented Mar 14, 2019

moog16 commented Mar 15, 2019

gugu commented Mar 1, 2019 •

edited

codecov-io commented Mar 4, 2019 •

edited

moog16 commented Mar 11, 2019 •

edited