fix(select): close select on menu close #4889
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43081j
force-pushed
the
select-clicks
branch
from
1f3d34a
to
6888e92
Compare
43081j
changed the title
43081j
force-pushed
the
select-clicks
branch
from
6888e92
to
ad234d0
Compare
43081j
force-pushed
the
select-clicks
branch
from
e21e0e2
to
8000978
Compare
43081j
force-pushed
the
select-clicks
branch
from
8000978
to
ece86c8
Compare
asyncLiz
requested changes
Feb 26, 2024
| @@ -48,6 +51,18 @@ export class SelectHarness extends Harness<Select> { | |||
| field.click(); | |||
| } | |||
|
|
|||
| async clickAndWaitForMenu() { | |||
There was a problem hiding this comment.
Could we override click() and wait for the menu's events there? I'm not sure when you'd want to click the element and not wait for all the events to settle.
There are some situations where the menu can close when the outer select is still open and unaware. For example, clicking the field will open the menu, then clicking it again will close the menu **but not the select**. This is because the menu observes outside clicks in order to close itself. We don't currently observe those closes to update our own state inside `md-select`, so the UI still shows as if it is open but without a menu. The fix here is to always reflect the state of the menu on `closed`.
43081j
force-pushed
the
select-clicks
branch
2 times, most recently
from
76537b0
to
58bea9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some situations where the menu can close when the outer select is still open and unaware.
For example, clicking the field will open the menu, then clicking it again will close the menu but not the select.
This is because the menu observes outside clicks in order to close itself. We don't currently observe those closes to update our own state inside
md-select, so the UI still shows as if it is open but without a menu.The fix here is to always reflect the state of the menu on
closed.Example of this bug: