Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(catalog): added fixed colors to the palette #5444

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vdegenne
Copy link
Contributor

@vdegenne vdegenne commented Feb 2, 2024

If you ever need to use fixed colors in some parts of the catalog, this PR adds them to the palette.
It also sorts and prettify the keys of the materialColors object.

@vdegenne vdegenne changed the title feat(catalog): Added fixed colors to the palette feat(catalog): added fixed colors to the palette Feb 2, 2024
@asyncLiz asyncLiz requested a review from e111077 February 2, 2024 19:53
@asyncLiz asyncLiz changed the title feat(catalog): added fixed colors to the palette fix(catalog): added fixed colors to the palette Feb 2, 2024
@asyncLiz asyncLiz added the preview-catalog Will run the github action to deploy a preview of the catalog label Feb 2, 2024
@vdegenne
Copy link
Contributor Author

vdegenne commented Feb 2, 2024

I will never get the titles right..

@asyncLiz
Copy link
Collaborator

asyncLiz commented Feb 2, 2024

I will never get the titles right..

haha nw, sorry 😅

The catalog isn't really a "feature" of @material/web, but it'd be nice to call it out. I wish there was a "chore" or "note"/"misc" section for the changelog.

@e111077 d'you know why the preview-catalog action isn't running? I'm assuming it's a permission thing.

@e111077
Copy link
Member

e111077 commented Feb 2, 2024

it fails the following check:

github.event.label.name == 'preview-catalog' && github.event.pull_request.head.repo.full_name == github.repository

This was meant to prevent this from running on forked repos. We can remove that if you want. I'm not sure why it's there. It might be a holdover or maybe the action I took it from had a reason to prevent abuse? IIRC we had an action using up our resources simply from running on a developer's forked repo's local development (no intention on merging back)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview-catalog Will run the github action to deploy a preview of the catalog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants