Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: buttons' appearance in disabled fieldset #5563

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

datvm
Copy link
Contributor

@datvm datvm commented Apr 3, 2024

Fix #5562

image

@datvm
Copy link
Contributor Author

datvm commented Apr 3, 2024

One change that is different compared to the others is:

.outlined:disabled .icon
// to
:host(:disabled) .outlined .icon {

Because the button inside the shadow root is not actually disabled. I don't think this should affect anything else.

@datvm
Copy link
Contributor Author

datvm commented Apr 3, 2024

A second commit also fixes other controls: Checkbox, Radio, Select, Slider and Switch.

image

Now this standalone commit does not help much as it doesn't fix the issue with #5409 but this commit prepares for when we fix that one. Right now the only way to test it is to put them in a disabled fieldset and then manually set their disabled to false (which means the fieldset is still disabled but each individual component is not).

@asyncLiz
Copy link
Collaborator

asyncLiz commented Apr 3, 2024

Thanks for this PR, I agree with your approach! There's a couple changes I'd like to make, so I'm going to import this directly for those to get it landed faster.

No action needed from you! Just don't push any more commits to this PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buttons' appearance in disabled fieldset
2 participants