Customization Hotkeys for Tiling Layouts #141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbil
reviewed
Dec 2, 2019
| @@ -4,12 +4,14 @@ const { | |||
| BaseGrabbableLayout | |||
| } = Me.imports.tilingManager.tilingLayouts.custom.baseGrabbable; | |||
|
|
|||
| let ratio = null; | |||
There was a problem hiding this comment.
this is only going to work if RatioLayout is always used as a singleton.
Suggest saving ratio as a member variable of RatioLayout (that gets initialized to global.tilingManager.ratio in the constructor).
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new keybindings,
Super+JandSuper+K. These keybindings interact with the current tiling layout to perform some kind of customization. At the moment, they control two layouts:While the event handlers and description text reference increasing and decreasing some variable, they could be mapped to other actions in the future.