Support configurable install location and bare make #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My motivation for this is to support NixOS which installs into a content-addressed directory layout and needs to be able to provide the location of the XDG share (specific to the package) Also it is more conventional to have the first target in make file do the 'full build', then the standard build of `make && make install` will work. I couldn't see a downside of adding this so I added an `all` target. For my purposes this makes the packaging for NixOS more minimal since I don't need to customise the standard builder (which is easy enough to do, but this seemed like a good thing to have anyway). Signed-off-by: Silas Davis <silas.davis@monax.io>
HalfVoxel
requested changes
Sep 28, 2022
|
|
||
| ifeq ($(XDG_DATA_HOME),) | ||
| export XDG_DATA_HOME = $(HOME)/.local/share | ||
| endif |
There was a problem hiding this comment.
It would be great with a comment explaining in which cases this is necessary :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My motivation for this is to support NixOS which installs into a
content-addressed directory layout and needs to be able to provide the
location of the XDG share (specific to the package)
Also it is more conventional to have the first target in make file do
the 'full build', then the standard build of
make && make installwillwork. I couldn't see a downside of adding this so I added an
alltarget. For my purposes this makes the packaging for NixOS more minimal
since I don't need to customise the standard builder (which is easy
enough to do, but this seemed like a good thing to have anyway).
Signed-off-by: Silas Davis silas.davis@monax.io