-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some minor fixes #962
base: main
Are you sure you want to change the base?
Some minor fixes #962
Conversation
uuid: string, | ||
...args: any[] | ||
) { | ||
if (incompatibleExtensions.includes(uuid)) return; | ||
// eslint-disable-next-line prefer-rest-params | ||
originalFunction!.apply(this, arguments); | ||
await originalFunction!.apply(this, arguments); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should return the orginalFunction
result instead of await
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's okay. Should I add an undefined
to the return in line 28, too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Returning nothing is similar as returning undefined
…nction The original method is defined as async. Hence, we need to pass through the return value of the originalFunction and in case of an early return, we need to return a resolved promise. https://github.com/GNOME/gnome-shell/blob/ba43c6191798dd07f66693ec90e2808ec9954e5c/js/ui/extensionSystem.js#L217
With parallel make execution the targets are run in parallel and you get the conflict: ``` % make compile rm -rf dist cp -r schemas dist mkdir dist glib-compile-schemas dist/schemas/ mkdir: cannot create directory ‘dist’: File exists ```
There are some changes in 4.8 and 4.9 they gives errors while compiling. Hence, pin the version to 4.6.x.
b08a10e
to
15ff308
Compare
No description provided.