Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Col delete func #3586

Merged
merged 12 commits into from
May 20, 2024
Merged

Col delete func #3586

merged 12 commits into from
May 20, 2024

Conversation

mathemancer
Copy link
Contributor

Fixes #3583

Adds a columns.delete function to the RPC endpoint.

Technical details

The function is documented in its docstring and the Mathesar docs, and said documentation should be sufficient.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@mathemancer mathemancer marked this pull request as ready for review May 15, 2024 07:42
@mathemancer
Copy link
Contributor Author

@Anish9901 Should be ready to review.

@mathemancer mathemancer added the pr-status: review A PR awaiting review label May 15, 2024
@mathemancer mathemancer added this to the Beta milestone May 15, 2024
@mathemancer mathemancer linked an issue May 15, 2024 that may be closed by this pull request
Copy link
Member

@Anish9901 Anish9901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me @mathemancer, please fix the name of the test that I've pointed down below and merge this.

assert result == 3


def test_get_column_info_for_table():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function name doesn't make sense.

@Anish9901 Anish9901 added pr-status: revision A PR awaiting follow-up work from its author after review and removed pr-status: review A PR awaiting review labels May 20, 2024
@Anish9901 Anish9901 assigned mathemancer and unassigned Anish9901 May 20, 2024
@mathemancer mathemancer merged commit fdc9353 into architectural_overhaul May 20, 2024
36 checks passed
@mathemancer mathemancer deleted the col_delete_func branch May 20, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: revision A PR awaiting follow-up work from its author after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement columns.delete RPC method
2 participants